From: Rotem Liss <rotem@users.mediawiki.org>
Date: Sun, 16 Sep 2007 03:38:37 +0000 (+0000)
Subject: Strike the link to the redirect rather than using an asterisk in Special:Listredirects
X-Git-Tag: 1.31.0-rc.0~51380
X-Git-Url: http://git.cyclocoop.org/%22.%24info%5B?a=commitdiff_plain;h=1ce76f5a646883e8d78bd118b8c9819c8271eee9;p=lhc%2Fweb%2Fwiklou.git

Strike the link to the redirect rather than using an asterisk in Special:Listredirects
---

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index 37c5d780a8..f2f4978277 100644
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -56,6 +56,7 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
 * Fix initial statistics when installing: add correct values
 * (bug 11342) Fix several 'returnto' links in permissions/error pages which
   linked to the main page instead of targetted page
+* Strike the link to the redirect rather than using an asterisk in Special:Listredirects
 
 
 === API changes in 1.12 ===
diff --git a/includes/SpecialListredirects.php b/includes/SpecialListredirects.php
index 581ea55b1f..92bd66e428 100644
--- a/includes/SpecialListredirects.php
+++ b/includes/SpecialListredirects.php
@@ -30,8 +30,7 @@ class ListredirectsPage extends QueryPage {
 	
 		# Make a link to the redirect itself
 		$rd_title = Title::makeTitle( $result->namespace, $result->title );
-		$arr = $wgContLang->getArrow() . $wgContLang->getDirMark();
-		$rd_link = $skin->makeKnownLinkObj( $rd_title, '', 'redirect=no' );
+		$rd_link = $skin->makeLinkObj( $rd_title, '', 'redirect=no' );
 
 		# Find out where the redirect leads
 		$revision = Revision::newFromTitle( $rd_title );
@@ -39,19 +38,15 @@ class ListredirectsPage extends QueryPage {
 			# Make a link to the destination page
 			$target = Title::newFromRedirect( $revision->getText() );
 			if( $target ) {
+				$arr = $wgContLang->getArrow() . $wgContLang->getDirMark();
 				$targetLink = $skin->makeLinkObj( $target );
+				return "$rd_link $arr $targetLink";
 			} else {
-				/** @todo Put in some decent error display here */
-				$targetLink = '*';
+				return "<s>$rd_link</s>";
 			}
 		} else {
-			/** @todo Put in some decent error display here */
-			$targetLink = '*';
+			return "<s>$rd_link</s>";
 		}
-
-		# Format the whole thing and return it
-		return "$rd_link $arr $targetLink";
-
 	}
 
 }